Cleanup duplicate logic and refactor installations.js into InstallationsRouter. #357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #334.
@drew-gross, what do you think about this approach over the custom function-based classes implementation that you have?
It's super clear what calls into what if we follow this approach.
Side-question - do we want/need to handle the same logic for
body.keys
/relations (redirectClassNameForKey
) as for all other Classes?Asking, 'for a friend', because we don't seem to do it right now.