Skip to content

flatten handles CallStacks #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2023
Merged

flatten handles CallStacks #27

merged 4 commits into from
Sep 8, 2023

Conversation

parsonsmatt
Copy link
Owner

Fixes #23

This PR adjusts flatten so that it appropriately handles CallStacks. Before this, you could get into trouble like this:

flatten (AnnotatedException [callStackAnnotation] (AnnotatedException [callStackAnnotation] TestException))
    = AnnotatedException [callStackAnnotation, callStackAnnotation] TestException

After this PR, the above will evaluate to:

flatten (AnnotatedException [callStackAnnotation] (AnnotatedException [callStackAnnotation] TestException))
    = AnnotatedException [mergeCallStacks callStackAnnotation callStackAnnotation] TestException

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR.
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

@parsonsmatt parsonsmatt merged commit 7087e08 into master Sep 8, 2023
@parsonsmatt parsonsmatt deleted the mattp/23-flatten-fix branch September 8, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flatten should use addCallStackToException
1 participant