pseudopatterns polluting base patterns

[bmuenzenmeyer]

Addresses #711

Summary of changes:

pseudopattern_hunter is performing a dangerous lodash merge against the base pattern data

//extend any existing data with variant data
variantFileData = _.merge(currentPattern.jsonFileData, variantFileData);

resulting in the mutation of the currentPattern.jsonFileData object.

Luckily, we get around this elsewhere by using jsonCopy on the merged objects.

I also verified this now using starterkit-mustache-demo.

FIX NOT APPLIED, DASHBOARD

(wrong data)

FIX NOT APPLIED, DASHBOARD ~ HACKED

(wrong data)

FIX APPLIED, DASHBOARD

(correct default data)

FIX APPLIED, DASHBOARD ~ HACKED

(correct override data)

[coveralls]

Coverage decreased (-0.2%) to 72.528% when pulling 2c8592a on fix/711-pseudopatterns into fca4d03 on dev.

[coveralls]

Coverage decreased (-0.2%) to 72.528% when pulling 2c8592a on fix/711-pseudopatterns into fca4d03 on dev.

[coveralls]

Coverage decreased (-0.2%) to 72.528% when pulling 2c8592a on fix/711-pseudopatterns into fca4d03 on dev.

[bmuenzenmeyer]

(code coverage decrease is likely due to deleting duplicate code, not the fix itself)