feat(Login): use children for loginmainfooterlinksitem #10107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-10107.surge.sh A11y report: https://patternfly-react-pr-10107-a11y.surge.sh |
tlabaj
requested review from
a team,
mattnolting,
tlabaj and
wise-king-sullyman
and removed request for
a team
|
@mcoker There's a |
|
@kmcfaul it looks good to me, though there are react-icons for all of the footer icons - should we use those instead? |
mcoker
approved these changes
Feb 28, 2024
tlabaj
reviewed
Feb 28, 2024
|
Waiting for alpha release before merging. |
wise-king-sullyman
approved these changes
Mar 4, 2024
tlabaj
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10100
Removes inner structure of
LoginMainFooterLinksItemand updates examples to pass buttons directly.