Skip to content

fix(charts) - ChartLegendTooltip.title has wrong type #10129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix(charts) - ChartLegendTooltip.title has wrong type #10129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/react-charts/src/components/ChartLegendTooltip/ChartLegendTooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { getTheme } from '../ChartUtils/chart-theme';
*
* See https://github.com/FormidableLabs/victory/blob/main/packages/victory-tooltip/src/index.d.ts
*/
export interface ChartLegendTooltipProps extends ChartCursorTooltipProps {
export interface ChartLegendTooltipProps extends Omit<ChartCursorTooltipProps, 'title'> {
/**
* The active prop specifies whether the tooltip component should be displayed.
*/
Expand Down Expand Up @@ -295,8 +295,11 @@ export interface ChartLegendTooltipProps extends ChartCursorTooltipProps {
themeColor?: string;
/**
* The title prop specifies a title to render with the legend.
*
* @propType number | string | Function | string[]
* @example title={(datum) => datum.x}
*/
title?: string;
title?: string[] | StringOrNumberOrCallback;
/**
* This prop refers to the width of the svg that ChartLegendTooltip is rendered within. This prop is passed from
* parents of ChartLegendTooltip, and should not be set manually. In versions before ^33.0.0 this prop referred to the
Expand Down