feat(Select, dropdown, options menu, contect selector, app launcher): Remove deprecated components #10345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Remove deprecated componets
|
Preview: https://patternfly-react-pr-10345.surge.sh A11y report: https://patternfly-react-pr-10345-a11y.surge.sh |
| newValue: string | SelectOptionObject, | ||
| isPlaceholder: boolean | ||
| newValue: any | any[] | ||
| // isPlaceholder: boolean |
There was a problem hiding this comment.
Do we intend to add this back in at any point?
There was a problem hiding this comment.
Thanks Eric. I did add updates for Editable table to my follow up issue #10365
| <MenuToggle ref={toggleRef} onClick={onToggle} isExpanded={isOpen}> | ||
| {isOpen ? 'Expanded' : 'Collapsed'} | ||
| </MenuToggle> | ||
| )} | ||
| > | ||
| {options} |
There was a problem hiding this comment.
I believe we'll need to import SelectList and wrap it around {options} here.
thatblindgeye
approved these changes
May 15, 2024
kmcfaul
approved these changes
May 16, 2024
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10143 #10316 #10141 #10140 #10139 #10138 #10137
Opened follow up issue to update failing integration tests and fix demo-app: #10365