chore(Demos): Replace notification buttons with NotificationBadge #11497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrances17
requested review from
thatblindgeye and
tlabaj
and removed request for
a team
|
Preview: https://patternfly-react-pr-11497.surge.sh A11y report: https://patternfly-react-pr-11497-a11y.surge.sh |
dlabaj
approved these changes
Feb 6, 2025
thatblindgeye
requested changes
Feb 6, 2025
mfrances17
force-pushed
the
notif-badge-demos
branch
from
ff2a7fa to
8898249
Compare
👍 Good catch, I was only searching in core. Fixed and made sure there were no other instances anywhere else. |
thatblindgeye
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Thanks for the updates.
I think this is more a core issue but I noticed the border changes to 2px width on hover which is different from our designs where we only change color not border-width. I'll confirm with @lboehling and @kaylachumley
andrew-ronaldson
approved these changes
Feb 11, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10625