Skip to content

Conversation

logonoff
Copy link
Member

What: Closes #11531

@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 13, 2025

Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to reproduce this bug exactly with our docs examples (maybe because its not contained in other components), but the change looks sound and doesn't introduce any new issues that I can find.

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this change in our chatbot extension and don't see any negative side effects to the code editors used in the extension. so LGTM ✅

@thatblindgeye thatblindgeye merged commit c06dbde into patternfly:main Feb 17, 2025
13 checks passed
@logonoff logonoff deleted the codeditor branch February 17, 2025 14:27
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - [CodeEditor] - Resize observer does not properly shrink CodeEditor

5 participants