Skip to content

Conversation

thatblindgeye
Copy link
Contributor

What: Closes #10583

Additional issues:

@thatblindgeye thatblindgeye requested review from a team, kaylachumley, mattnolting, mfrances17 and tlabaj and removed request for a team February 17, 2025 18:20
@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 17, 2025

Copy link
Contributor

@mfrances17 mfrances17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@kaylachumley kaylachumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! everything is looking pretty good! Quick Q: I noticed that for the 3 in page demos, the height of the wizard is being maxed at 250px so you can't see the full height of the content unless you scroll, is that intentional?
Screenshot 2025-02-18 at 4 56 26 PM

@thatblindgeye
Copy link
Contributor Author

@kaylachumley ah good catch, looks like those demos were rendering an unnecessary wrapper element. Removed it and those demos should look more like the Core demos now.

Copy link

@kaylachumley kaylachumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazinggg - ty!

Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kmcfaul kmcfaul merged commit b3a59bc into patternfly:main Feb 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wizard: react demo needs updated

5 participants