Skip to content

feat(Toolbar): Add row wrap prop to ToolbarGroup and ToolbarItem #11559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 11, 2025
Merged

feat(Toolbar): Add row wrap prop to ToolbarGroup and ToolbarItem #11559

merged 5 commits into from
Mar 11, 2025

Conversation

mfrances17
Copy link
Contributor

What: Closes #11489

@mfrances17 mfrances17 requested review from a team, mcoker and thatblindgeye February 24, 2025 22:54
@mfrances17 mfrances17 self-assigned this Feb 24, 2025
@mfrances17 mfrances17 requested review from tlabaj and removed request for a team February 24, 2025 22:54
@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 24, 2025 •
edited
Loading

Preview: https://patternfly-react-pr-11559.surge.sh

A11y report: https://patternfly-react-pr-11559-a11y.surge.sh

mcoker
mcoker requested changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of things:

thatblindgeye
thatblindgeye reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to adding the prop to ToolbarContent (for the ContentSection class), could we add a simple example for that? Maybe we could update the section from "Examples with toolbar spacers" to "Examples with spacers and wrapping", then add a "Toolbar content wrapping" example to show the nowrap modifier in use (the example description could mention that by default the content section wraps).

Also can we add quick unit tests for these components for the new modifier as well

@mfrances17
Copy link
Contributor Author

thanks @mcoker & @thatblindgeye, i've added a wrap prop to ToolbarContent, added an example showing the behavior with nowrap, and changed the examples section as suggested. Added tests for ToolbarContent wrap as well, in addition to the tests I added on my previous commit for ToolbarGroup and ToolbarItem wrapping.

mcoker
mcoker approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM!! ✅

tlabaj
tlabaj requested changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one ask.

@thatblindgeye thatblindgeye merged commit 6b1646f into patternfly:main Mar 11, 2025
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

@thatblindgeye thatblindgeye mentioned this pull request Mar 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcoker mcoker mcoker approved these changes

@tlabaj tlabaj tlabaj approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees

@mfrances17 mfrances17

Labels

css review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Toolbar - add a wrap prop for ToolbarGroup and ToolbarItem gap

6 participants

@mfrances17 @patternfly-build @mcoker @tlabaj @kmcfaul @thatblindgeye