chore(pagination): rename Navigation to PaginationNavigation #11664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11664.surge.sh A11y report: https://patternfly-react-pr-11664-a11y.surge.sh |
thatblindgeye
requested changes
Mar 13, 2025
|
|
||
| class Navigation extends Component<NavigationProps, NavigationState> { | ||
| static displayName = 'Navigation'; | ||
| class PaginationNavigation extends Component<NavigationProps, NavigationState> { |
There was a problem hiding this comment.
We should also update the NavigationProps and NavigationState.
There was a problem hiding this comment.
I was also thinking the same, maybe I forgot to ask here. Will make the necessary changes.
thatblindgeye
approved these changes
Mar 13, 2025
tlabaj
approved these changes
Mar 17, 2025
dlabaj
pushed a commit
that referenced
this pull request
Apr 17, 2025
* chore(pagination): rename Navigation to PaginationNavigation * renamed test file * rename navigation props and state
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8416