Skip to content

chore(expandable section): improve toggle text to be descriptive #11737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 10, 2025
Merged

chore(expandable section): improve toggle text to be descriptive #11737

merged 4 commits into from
Apr 10, 2025

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented Apr 2, 2025

Closes #11394

@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 2, 2025 •
edited
Loading

Preview: https://patternfly-react-pr-11737.surge.sh

A11y report: https://patternfly-react-pr-11737-a11y.surge.sh

@Mash707
Copy link
Contributor Author

Mash707 commented Apr 2, 2025

I have not changed the "With custom toggle content" example as it already has a descriptive text, let me if it needs to be changed.

thatblindgeye
thatblindgeye requested changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update the "Show less" toggle text similarly for each example, so "Show less basic example content" and so on

@Mash707
Copy link
Contributor Author

Mash707 commented Apr 9, 2025 •
edited
Loading

I did think about this since the example "Indented expandable content" already had a expanded section by default. Forgot to ask ig, anyways will make the changes.

@Mash707 Mash707 force-pushed the improve-toggle-text-to-be-descriptive branch from 753dd98 to 908023b Compare April 9, 2025 22:42
@Mash707 Mash707 requested a review from thatblindgeye April 9, 2025 22:48
@thatblindgeye thatblindgeye merged commit 42fb3b6 into patternfly:main Apr 10, 2025
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

dlabaj pushed a commit that referenced this pull request Apr 17, 2025
@Mash707 @dlabaj
chore(expandable section): improve toggle text to be descriptive (#11737
03a9812 
)

* chore(expandable section): improve toggle text to be descriptive

* updated expandable text demo

* updated show less toggle text

* updated demo show less toggle text
@Mash707 Mash707 deleted the improve-toggle-text-to-be-descriptive branch May 21, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmcfaul kmcfaul kmcfaul approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ExpandableSection - toggle text should be more descriptive in examples

4 participants

@Mash707 @patternfly-build @kmcfaul @thatblindgeye