-
Notifications
You must be signed in to change notification settings - Fork 371
chore(miscellaneous): remove unnecessary eslint disable camelcase comments #11796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(miscellaneous): remove unnecessary eslint disable camelcase comments #11796
Conversation
Preview: https://patternfly-react-pr-11796.surge.sh A11y report: https://patternfly-react-pr-11796-a11y.surge.sh |
@thatblindgeye have a look. I ran the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Am noticing there's some other files still disabling the camelcase rule that weren't part of the original update for global and chart tokens.
Because of what those ones are being used for (one being an image import, the others being component CSS var tokens), I think it would make sense to follow how MenuContent is importing similar tokens:
import cssHeight from '@patternfly/react-tokens/dist/esm/c_menu__content_Height'; | |
import cssMaxHeight from '@patternfly/react-tokens/dist/esm/c_menu__content_MaxHeight'; |
Rather than importing something like c_page_section_m_limit_width_MaxWidth
, we just import as camelcased in the above file. So something like import pageSectionWidthLimitMaxWidth
maybe and so on. There's only 6 of these instances left, would you want to make updates for this @Mash707 ?
Sure I'll update them. |
Updated the usage as per
|
…ments (patternfly#11796) * chore(charts): remove unnecessary eslint disable camelcase comments * remove eslint disable comments * removed extra spaces * update remaining tokens to use camelcase * updated CardDemos.md * updated page.md
Closes #11789