Skip to content

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented Apr 29, 2025

Closes #11789

@Mash707 Mash707 changed the title chore(charts): remove unnecessary eslint disable camelcase comments chore(miscellaneous): remove unnecessary eslint disable camelcase comments Apr 29, 2025
@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 29, 2025

@Mash707
Copy link
Contributor Author

Mash707 commented Apr 29, 2025

@thatblindgeye have a look. I ran the yarn lint to check if I am not missing any files.
Also changed the title for the PR since it was covering a lot of different files, mostly due to variables starting with t_global

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Am noticing there's some other files still disabling the camelcase rule that weren't part of the original update for global and chart tokens.

Because of what those ones are being used for (one being an image import, the others being component CSS var tokens), I think it would make sense to follow how MenuContent is importing similar tokens:

import cssHeight from '@patternfly/react-tokens/dist/esm/c_menu__content_Height';
import cssMaxHeight from '@patternfly/react-tokens/dist/esm/c_menu__content_MaxHeight';

Rather than importing something like c_page_section_m_limit_width_MaxWidth, we just import as camelcased in the above file. So something like import pageSectionWidthLimitMaxWidth maybe and so on. There's only 6 of these instances left, would you want to make updates for this @Mash707 ?

@Mash707
Copy link
Contributor Author

Mash707 commented Apr 29, 2025

Sure I'll update them.

@Mash707 Mash707 requested a review from thatblindgeye April 29, 2025 19:15
@Mash707
Copy link
Contributor Author

Mash707 commented Apr 29, 2025

Updated the usage as per

import cssGridTemplateColumnsMin from '@patternfly/react-tokens/dist/esm/l_gallery_GridTemplateColumns_min';

@thatblindgeye thatblindgeye requested a review from kmcfaul May 6, 2025 13:05
@nicolethoen nicolethoen merged commit e49fd8d into patternfly:main May 15, 2025
13 checks passed
@Mash707 Mash707 deleted the charts-remove-eslint-disable-camelcase branch May 15, 2025 16:32
mattnolting pushed a commit to mattnolting/patternfly-react that referenced this pull request Jun 4, 2025
…ments (patternfly#11796)

* chore(charts): remove unnecessary eslint disable camelcase comments

* remove eslint disable comments

* removed extra spaces

* update remaining tokens to use camelcase

* updated CardDemos.md

* updated page.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Miscellaneous - Remove unnecessary eslint-disable camelcase comments after config update

4 participants