-
Notifications
You must be signed in to change notification settings - Fork 371
feat(templates): allow react 19 #12046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates): allow react 19 #12046
Conversation
Preview: https://pf-react-pr-12046.surge.sh A11y report: https://pf-react-pr-12046-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how else to verify, but it does build correctly when I change the React versions in the repo - checked 17, 18, and 19. 18 runs. 19 fails due to docs framework as expected.
17 fails with these - doesn't seem like you though?:
[1] WARNING in ./patternfly-docs/generated/charts/line-chart/ECharts.js 361:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/charts/sankey-chart/ECharts.js 361:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/components/menus/dropdown/react-templates.js 102:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/components/menus/select/react-templates.js 162:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/components/table/react-demos.js 65:2-11
[1] export 'ReactNode' (imported as 'ReactNode') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] webpack 5.94.0 compiled with 5 warnings in 30044 ms
[1] <i> [webpack-dev-middleware] wait until bundle finished: /components/modal
[1] 413 assets
[1] 5587 modules
[1]
[1] WARNING in ./patternfly-docs/generated/charts/line-chart/ECharts.js 361:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/charts/sankey-chart/ECharts.js 361:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/components/menus/dropdown/react-templates.js 102:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/components/menus/select/react-templates.js 162:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
[1] WARNING in ./patternfly-docs/generated/components/table/react-demos.js 65:2-11
[1] export 'ReactNode' (imported as 'ReactNode') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1]
Hm might be our docs framework again still. At least, it seems to be more than just the templates that it's complaining about. |
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #12014