Skip to content

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Oct 9, 2025

What: Closes #12014

@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 9, 2025

Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how else to verify, but it does build correctly when I change the React versions in the repo - checked 17, 18, and 19. 18 runs. 19 fails due to docs framework as expected.

17 fails with these - doesn't seem like you though?:

[1] WARNING in ./patternfly-docs/generated/charts/line-chart/ECharts.js 361:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1] 
[1] WARNING in ./patternfly-docs/generated/charts/sankey-chart/ECharts.js 361:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1] 
[1] WARNING in ./patternfly-docs/generated/components/menus/dropdown/react-templates.js 102:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1] 
[1] WARNING in ./patternfly-docs/generated/components/menus/select/react-templates.js 162:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1] 
[1] WARNING in ./patternfly-docs/generated/components/table/react-demos.js 65:2-11
[1] export 'ReactNode' (imported as 'ReactNode') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1] 
[1] webpack 5.94.0 compiled with 5 warnings in 30044 ms
[1] <i> [webpack-dev-middleware] wait until bundle finished: /components/modal
[1] 413 assets
[1] 5587 modules
[1] 
[1] WARNING in ./patternfly-docs/generated/charts/line-chart/ECharts.js 361:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1] 
[1] WARNING in ./patternfly-docs/generated/charts/sankey-chart/ECharts.js 361:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1] 
[1] WARNING in ./patternfly-docs/generated/components/menus/dropdown/react-templates.js 102:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1] 
[1] WARNING in ./patternfly-docs/generated/components/menus/select/react-templates.js 162:2-19
[1] export 'FunctionComponent' (imported as 'FunctionComponent') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1] 
[1] WARNING in ./patternfly-docs/generated/components/table/react-demos.js 65:2-11
[1] export 'ReactNode' (imported as 'ReactNode') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
[1] 

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Oct 10, 2025

Hm might be our docs framework again still. At least, it seems to be more than just the templates that it's complaining about.

@wise-king-sullyman wise-king-sullyman merged commit 38727b6 into patternfly:main Oct 13, 2025
13 of 14 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - react-templates - Support of react 19

5 participants