fix(Truncate): remove resize observer

[gitdallas]

What: Closes #10974

[patternfly-build]

Preview: https://pf-react-pr-12055.surge.sh

A11y report: https://pf-react-pr-12055-a11y.surge.sh

[rebeccaalpert]

I'd want to make sure that #11811 still works - noting this down so I don't forget when I come back to review this.

[thatblindgeye]

One issue with this update is that the truncate always has a tabindex of 0 now, when it should really only have that when truncation is actually in effect. Otherwise potentially a lot of static text that isn't truncated will just add an equal amount of unneccessary tab stops to the page.

[gitdallas]

@thatblindgeye - looks like i can set isTruncated to false originally and then it seems to work initially, however it won't update if something is resized.. maybe that doesn't matter as much as the performance? because i'm not sure if there is a better way to do this without adding the resizeObserver back

[thatblindgeye]

looks like i can set isTruncated to false originally and then it seems to work initially, however it won't update if something is resized.. maybe that doesn't matter as much as the performance? because i'm not sure if there is a better way to do this without adding the resizeObserver back

I think both are important, though I don't know which (if either) is more important. That's probably a lengthier discussion.

@christianvogt for your use case, are you taking advantage of the resizability of the Truncate component, i.e. whether the content is actually truncated or not can change depending on the viewport width or the content can be of varying length? Or is it pretty reliable that wherever Truncate is being used things will always be Truncated or always not be Truncated (like in a Table column that is always fairly narrow)?

Mainly asking because if it's the latter - and assuming using the maxCharsDisplayed prop isn't viable - I wonder if adding a prop to dictate whether the resize observer is even used would be useful (or debouncing the resize observer).

[christianvogt]

I believe when I created the original issue it was because the component was unmounting and remounting needlessly. Secondary after looking into the code I made the comment about performance and the potential to omit the resize handler. However I didn't consider the tab index case.

For our use case I would still like the text react to container size.