Skip to content

chore(Console): Add skeleton of @patternfly-react/console package #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2018

Conversation

dmiller9911
Copy link
Contributor

Wondering the best course of action for this. Merge into master and have the feature branches rebase and move, or merge this fork into those and then merge it along with them.

What:
Added a skeleton for the console package under packages/console. This package will include the upcoming VncConsole and SerialConsole.

Link to Storybook:

Additional issues:

@coveralls
Copy link

coveralls commented Apr 18, 2018

Pull Request Test Coverage Report for Build 1216

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 76.246%

Totals Coverage Status
Change from base Build 1213: 0.08%
Covered Lines: 1615
Relevant Lines: 1932

💛 - Coveralls

@priley86
Copy link
Member

priley86 commented Apr 18, 2018

i'm in favor of merging this before #288 once you have publish script ready... but will wait to see what others think. Are you planning to add a lerna script? or just a simple npm publish for that one? Semantic release can only publish the one in the root right now...

@jeff-phillips-18
Copy link
Member

I'd agree with @priley86, merge this first.

@dmiller9911
Copy link
Contributor Author

dmiller9911 commented Apr 18, 2018

@priley86 That was another question. Are we doing the publish manually? If so I'll throw a yarn publish at the end. If we want the ci to do it we might want to just move everything to lerna or yarn workspaces now since it is similar effort.

@dmiller9911 dmiller9911 force-pushed the console-package branch 2 times, most recently from 05093aa to 00f7ae1 Compare April 18, 2018 14:46
@@ -0,0 +1 @@
# @patternfly-react/console
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need some notes here? i think we should mention the scripts added above and also mention this is an interim solution until we are on the lerna path...

Added a skelton for the console package under `packages/console`. This package will include the upcoming VncConsole and SerialConsole.
@dmiller9911 dmiller9911 changed the title chore(Console): WIP Add skeleton of @patternfly-react/console package chore(Console): Add skeleton of @patternfly-react/console package Apr 20, 2018
@jeff-phillips-18 jeff-phillips-18 merged commit 4a69ebd into patternfly:master Apr 23, 2018
glekner pushed a commit to glekner/patternfly-react that referenced this pull request Apr 26, 2018
…tternfly#311)

Added a skelton for the console package under `packages/console`. This package will include the upcoming VncConsole and SerialConsole.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants