chore(Console): Add skeleton of @patternfly-react/console package #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1216
💛 - Coveralls |
|
i'm in favor of merging this before #288 once you have publish script ready... but will wait to see what others think. Are you planning to add a lerna script? or just a simple |
|
I'd agree with @priley86, merge this first. |
|
@priley86 That was another question. Are we doing the publish manually? If so I'll throw a yarn publish at the end. If we want the ci to do it we might want to just move everything to lerna or yarn workspaces now since it is similar effort. |
dmiller9911
force-pushed
the
console-package
branch
2 times, most recently
from
05093aa to
00f7ae1
Compare
priley86
reviewed
Apr 18, 2018
| @@ -0,0 +1 @@ | |||
| # @patternfly-react/console | |||
There was a problem hiding this comment.
still need some notes here? i think we should mention the scripts added above and also mention this is an interim solution until we are on the lerna path...
Added a skelton for the console package under `packages/console`. This package will include the upcoming VncConsole and SerialConsole.
dmiller9911
force-pushed
the
console-package
branch
from
00f7ae1 to
a2c649a
Compare
dmiller9911
changed the title
jeff-phillips-18
approved these changes
Apr 23, 2018
priley86
approved these changes
Apr 23, 2018
This was referenced Apr 23, 2018
glekner
pushed a commit
to glekner/patternfly-react
that referenced
this pull request
Apr 26, 2018
…tternfly#311) Added a skelton for the console package under `packages/console`. This package will include the upcoming VncConsole and SerialConsole.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wondering the best course of action for this. Merge into master and have the feature branches rebase and move, or merge this fork into those and then merge it along with them.
What:
Added a skeleton for the console package under
packages/console. This package will include the upcoming VncConsole and SerialConsole.Link to Storybook:
Additional issues: