-
Notifications
You must be signed in to change notification settings - Fork 370
chore(Console): Add skeleton of @patternfly-react/console package #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Console): Add skeleton of @patternfly-react/console package #311
Conversation
Pull Request Test Coverage Report for Build 1216
💛 - Coveralls |
i'm in favor of merging this before #288 once you have publish script ready... but will wait to see what others think. Are you planning to add a lerna script? or just a simple |
I'd agree with @priley86, merge this first. |
@priley86 That was another question. Are we doing the publish manually? If so I'll throw a yarn publish at the end. If we want the ci to do it we might want to just move everything to lerna or yarn workspaces now since it is similar effort. |
05093aa
to
00f7ae1
Compare
@@ -0,0 +1 @@ | |||
# @patternfly-react/console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still need some notes here? i think we should mention the scripts added above and also mention this is an interim solution until we are on the lerna path...
Added a skelton for the console package under `packages/console`. This package will include the upcoming VncConsole and SerialConsole.
00f7ae1
to
a2c649a
Compare
…tternfly#311) Added a skelton for the console package under `packages/console`. This package will include the upcoming VncConsole and SerialConsole.
Wondering the best course of action for this. Merge into master and have the feature branches rebase and move, or merge this fork into those and then merge it along with them.
What:
Added a skeleton for the console package under
packages/console
. This package will include the upcoming VncConsole and SerialConsole.Link to Storybook:
Additional issues: