Skip to content

chore(demo app): Fix build of demo app and center graph initially #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

jeff-phillips-18
Copy link
Member

Description

The demo application does not build due to:

ERROR in src/App.tsx:38:19
TS2686: 'React' refers to a UMD global, but the current file is a module. Consider adding an import instead.
    36 | }
    37 |
  > 38 | class App extends React.Component<{}, AppState> {

Fixing this issue reveals that the graph is no longer being centered in the TopologyPackage demo.

This PR fixes the build issue and fixes centering the graph in the demo

Type of change

  • Other (please describe): Fixes the example/demo application

@patternfly-build
Copy link

Copy link
Collaborator

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jeff-phillips-18 ! Graph centering looks awesome - I'm still seeing a couple of errors being thrown by webpack in the demo-app build which we can resolve with these two quick fixes - PRed your changes: jeff-phillips-18#2

Copy link
Collaborator

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeff-phillips-18 ! Tested in docs workspace and demo app. Graph centering now works as expected and demo app builds successfully. LGTM

@jeff-phillips-18 jeff-phillips-18 merged commit aad57e0 into patternfly:main Jun 23, 2025
8 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the demo-app-fixes branch June 23, 2025 11:37
Copy link

github-actions bot commented Jul 1, 2025

🎉 This PR is included in version 6.3.0-prerelease.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants