-
-
Notifications
You must be signed in to change notification settings - Fork 3
update to support descriptions with file links #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
logan-markewich
wants to merge
3
commits into
pawamoy:main
Choose a base branch
from
logan-markewich:logan/add_link_description
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
update to support descriptions with file links #8
logan-markewich
wants to merge
3
commits into
pawamoy:main
from
logan-markewich:logan/add_link_description
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianlyjak
reviewed
May 10, 2025
|
||
```yaml title="mkdocs.yml" | ||
plugins: | ||
- llmstxt: | ||
sections: | ||
Usage documentation: | ||
- index.md | ||
- usage/*.md | ||
index.md: Main documentation page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'd need the dashes here still, no? this doesn't look legal on the next line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So from what I understand:
- if you are using descriptions, this format is correct
- the old format (just a list using dashes) also still works
adrianlyjak
reviewed
May 10, 2025
adrianlyjak
reviewed
May 10, 2025
adrianlyjak
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new config options to provide a description with each page link
Which would generate something like
Added some unit tests, so I think this will work nicely? Open to changes!