Skip to content

auth.disableLocalStrategy should accept false as a value #9197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tyteen4a03 opened this issue Nov 14, 2024 · 2 comments
Closed

auth.disableLocalStrategy should accept false as a value #9197

tyteen4a03 opened this issue Nov 14, 2024 · 2 comments

Comments

@tyteen4a03
Copy link
Contributor

Describe the Bug

The current type definitions do not accept disableLocalStrategy as false. This breaks scenarios such as disableLocalStrategy: process.env.NODE_ENV === 'production'.

Link to the code that reproduces this issue

N/A

Reproduction Steps

Specify false as a value for disableLocalStrategy.

Which area(s) are affected? (Select all that apply)

area: core

Environment Info

Node.js v22.11.0

Binaries:
  Node: 22.11.0
  npm: 10.9.0
  Yarn: N/A
  pnpm: 9.12.1
Relevant Packages:
  payload: 3.0.0-beta.130
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 24.1.0: Thu Oct 10 21:03:15 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6000
  Available memory (MB): 32768
  Available CPU cores: 10
@tyteen4a03 tyteen4a03 added status: needs-triage Possible bug which hasn't been reproduced yet v3 validate-reproduction Auto-added tag on create to tell bot to check recreation URL, removed after check. labels Nov 14, 2024
@github-actions github-actions bot added created-by: Contributor and removed validate-reproduction Auto-added tag on create to tell bot to check recreation URL, removed after check. labels Nov 14, 2024
Copy link
Contributor

Please add a reproduction in order for us to be able to investigate.

Depending on the quality of reproduction steps, this issue may be closed if no reproduction is provided.

Why was this issue marked with the invalid-reproduction label?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We prefer a link to a public GitHub repository created with create-payload-app@beta -t blank or a forked/branched version of this repository with tests added (more info in the reproduction-guide).

To make sure the issue is resolved as quickly as possible, please make sure that the reproduction is as minimal as possible. This means that you should remove unnecessary code, files, and dependencies that do not contribute to the issue. Ensure your reproduction does not depend on secrets, 3rd party registries, private dependencies, or any other data that cannot be made public. Avoid a reproduction including a whole monorepo (unless relevant to the issue). The easier it is to reproduce the issue, the quicker we can help.

Please test your reproduction against the latest version of Payload to make sure your issue has not already been fixed.

I added a link, why was it still marked?

Ensure the link is pointing to a codebase that is accessible (e.g. not a private repository). "example.com", "n/a", "will add later", etc. are not acceptable links -- we need to see a public codebase. See the above section for accepted links.

Useful Resources

@denolfe denolfe removed the v3 label Nov 19, 2024
@jessrynkar
Copy link
Member

jessrynkar commented May 6, 2025

Hi @tyteen4a03, thanks for raising this! I can see why you'd want to do this, but in this case, the type is intentionally optional — so instead of passing false, the recommended approach is to set it to undefined.

E.g. disableLocalStrategy: process.env.NODE_ENV === 'production' ? true : undefined.

That will have the same effect and will fit within the current type definitions.

@github-actions github-actions bot removed the status: needs-triage Possible bug which hasn't been reproduced yet label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants