Skip to content

chore: assign available port to env variable in dev suite #12092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

paulpopus
Copy link
Contributor

Previously when the port number was bumped up (eg 3001) in our dev suite, HMR wouldn't work because it couldn't reliably read the new used port and it would default to 3000.

This assigns it properly to the env var and fixes that issues so HMR in our dev suite works on other ports too.

Testing steps:

  • Have a local instance of dev suite running already on port 3000
  • New repo run dev, it will bump to 3001
  • Make any config change and you will see that HMR does not work without this fix

@paulpopus paulpopus enabled auto-merge (squash) April 11, 2025 19:08
@paulpopus paulpopus merged commit 39462bc into main Apr 11, 2025
80 checks passed
@paulpopus paulpopus deleted the chore/assign-available-port-to-env-variable-in-dev-suite branch April 11, 2025 19:24
Copy link
Contributor

🚀 This is included in version v3.35.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants