Skip to content

fix: duplicate with orderable #12274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

fix: duplicate with orderable #12274

merged 1 commit into from
Apr 30, 2025

Conversation

r1tsuu
Copy link
Member

@r1tsuu r1tsuu commented Apr 30, 2025 •
edited
Loading

Previously, duplication with orderable collections worked incorrectly, for example

Document 1 is created - _order: 'a5'
Document 2 is duplicated from 1, - _order: 'a5 - copy' (result from

payload/packages/payload/src/fields/setDefaultBeforeDuplicate.ts

Line 6 in 47a1eee

const unique: FieldHook = ({ value }) => (isStringValue(value) ? `${value} - Copy` : undefined)
)

Now, the _order value is re-calculated properly.

@r1tsuu r1tsuu enabled auto-merge (squash) April 30, 2025 17:14
@r1tsuu r1tsuu merged commit 710fe09 into main Apr 30, 2025
83 checks passed
@r1tsuu r1tsuu deleted the fix/orderable-duplicate branch April 30, 2025 17:28
@github-actions GitHub Actions
Copy link
Contributor

🚀 This is included in version v3.36.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanRibbens DanRibbens DanRibbens approved these changes

Assignees
No one assigned
Labels
created-by: Payload team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r1tsuu @DanRibbens