Skip to content

Change props.spec to props.options #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Change props.spec to props.options #1

merged 1 commit into from
Sep 15, 2023

Conversation

pearmini
Copy link
Owner

Refactor props

  • Remove props.spec
  • Add props.options

Example

// Before
export function Demo() {
  return (
    <Chart
      spec={{
        type: "interval",
        data: [
          { genre: "Sports", sold: 275 },
          { genre: "Strategy", sold: 115 },
          { genre: "Action", sold: 120 },
          { genre: "Shooter", sold: 350 },
          { genre: "Other", sold: 150 },
        ],
        encode: { x: "genre", y: "sold" },
      }}
      options={{
        renderer: new Renderer(),
        autoFit: true,
      }}
    />
  );
}
// After
export function Demo() {
  return (
    <Chart
     options={{
        type: "interval",
        autoFit: true,
        data: [
          { genre: "Sports", sold: 275 },
          { genre: "Strategy", sold: 115 },
          { genre: "Action", sold: 120 },
          { genre: "Shooter", sold: 350 },
          { genre: "Other", sold: 150 },
        ],
        encode: { x: "genre", y: "sold" },
      }}
      renderer={new Renderer()}
    />
  );
}

@pearmini pearmini requested review from lvisei and xiaoiver and removed request for lvisei and xiaoiver September 15, 2023 02:34
@pearmini pearmini merged commit 1aa7bbf into main Sep 15, 2023
@pearmini pearmini deleted the refactor-api branch September 15, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants