misc fixes key.py #200
Merged
misc fixes key.py #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markblundeberg
commented
Feb 3, 2019
markblundeberg
commented
- BN_bin2bn happy to take null ptr as arg and do allocation.
- EC_POINT_mul hears you the first time, don't need to call twice.
- EC_KEY_set_private_key makes a copy of the key; without freeing it we have a memory leak.
* EC_POINT_mul hears you the first time, don't need to call twice. * EC_KEY_set_private_key makes a copy of the key; without freeing it we have a memory leak. * BN_bin2bn happy to take None as arg and do allocation.
cculianu
reviewed
May 9, 2019
| _ssl.EC_KEY_set_private_key(self.k, priv_key) | ||
| _ssl.EC_KEY_set_public_key(self.k, pub_key) | ||
| _ssl.EC_POINT_free(pub_key) | ||
| _ssl.BN_free(priv_key) |
There was a problem hiding this comment.
This is key. Get it?
Yes, you really need to free your private keys from memory.
petertodd
added a commit
that referenced
this pull request
May 19, 2019
c31b6e7 misc fixes key.py (Mark B Lundeberg) Pull request description: * BN_bin2bn happy to take null ptr as arg and do allocation. * EC_POINT_mul hears you the first time, don't need to call twice. * EC_KEY_set_private_key makes a copy of the key; without freeing it we have a memory leak. Tree-SHA512: 6557c788c27933ee1dc3d6085f3c3f259ed0547811c1a3f7bd3679f8ee664772a53cca81a56e6dfac2eaecea613d006b1c5ccaedc7c7ccd121a15fcd41fb58fb
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.