Elements with maxrepeat > 1 should be considered arrays when parsed as json

[proggeler]

When using EDI\Interpreter::getJson(); it would be very helpful if the parts within the json would have a consistent type.

For example: According to the INVOIC (D96A) message the message can contain up to 35 DTM entries.
This causes for a lot of if statements within code that processes these date entries:

$invoices = json_decode($interpreter->getJson());
$invoice = $invoices[0];

if (!is_array($invoice->datetimeperiod)) {
    // ensure it is an array before processing it (maxrepeat = 35)
    $invoice->datetimeperiod = [$invoice->datetimeperiod->datetimeperiod];
}
$dates = [];
foreach ($invoice->datetimeperiod as $datetimeperiod) {
    if ($datetimeperiod->datetimeperiodFormatQualifier == 102) {
        $dates[] = DateTimeImmutable::createFromFormat('Ymd', $datetimeperiod->datetimeperiod); 
    }
}

This check for the array needs to be done for all the elements that have a maxrepeat > 1.

If the maxrepeat > 1 is used by the interpreter to force an array, implementation would be more predictable and the code would be more clean.

This also counts for EDI\Interpreter::getArrayy()->getArray(true)

[sabas]

Hi @proggeler thank you for the feedback!
Are you using the latest version? We introduced a forceArrayWhenRepeatable flag that I think it's what you are looking for (I wanted not to make it default not to break previous implementations), also we should have removed Arrayy from the code...

[proggeler]

@sabas I was using version 0.6.1. Version 0.7.0 triggers an error when this flag is true. I think you had some debug function called d() in the Interpreter on line 600. Removing that line will do the trick.

BTW: from 0.6.x to 0.7.x you are allowed to have backward breaking code, but I like your backwards compatible approach.
Update using composer update will ignore version update from 0.6 to 0.7. composer require php-edifact/edifact:^0.7 is needed in case (even if you had an earlier version installed). Composer will work like this until the first stable version: 1.0.0.

[sabas]

Fine I'll tag 1.0, it's time... :D

[proggeler]

@sabas shall I fix the Interpreter via a pull request or is that to much overhead for just one line removing

[proggeler]

@sabas thank you for your support

[sabas]

Try now, the debug line was removed already in a commit.. For the future keep in mind that also a one line fix is accepted :)