Encoder double escapes values

[wendelin]

In the function "EDI/Encoder->escapeValue" the replace order leads to data separators being replaced before any escape characters.

UNA:+.?*'
"my+value" encodes to "my??+value"

Could someone please change that so escape characters are escaped first before the other characters?

[sabas]

Could you provide a (minimal) sample of the array to encode which reproduces the problem? Thanks! 😊

[wendelin]

Sorry forgot about that.

Test code:

require(__DIR__ . '/vendor/autoload.php');
header("Content-Type: text/plain; charset=utf-8");
$encoder = new \EDI\Encoder();
$encoder->setUNA(":+.?*'");
$encoder->encode($fragments = [
	// ...
	["IMD","F",[],["CU","","9","Widget - contains: Foo + Bar, or does it?","","DE"]]
	// ...
]);
print_r([ '$fragments' => $fragments ]);
print_r([ '$encoder->get()' => $encoder->get()]);

Returns:

Array
(
    [$encoder->get()] => UNA:+.?*'IMD+F++CU::9:Widget - contains??: Foo ??+ Bar, or does it??::DE'
)

Expected output:

Array
(
    [$encoder->get()] => UNA:+.?*'IMD+F++CU::9:Widget - contains?: Foo ?+ Bar, or does it??::DE'
)

[wendelin]

Proposed fix:
Move symbRel replacement to the start.

    private function escapeValue($str)
    {
        $search = [
            $this->symbRel,
            $this->sepComp,
            $this->sepData,
            $this->symbEnd
        ];
        $replace = [
            $this->symbRel . $this->symbRel,
            $this->symbRel . $this->sepComp,
            $this->symbRel . $this->sepData,
            $this->symbRel . $this->symbEnd
        ];
        return str_replace($search, $replace, $str);
    }

[sabas]

Ok, I can reproduce. Can you fork and submit a pull request, so your name will be in the repository? :-)

[wendelin]

How is this?
#76

[sabas]

Thank you !