Skip to content

PHP 7.2 Compatibility (+ updated php-cs-fixer & PHPUnit) #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 5, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated docks & readme
  • Loading branch information
mrwogu committed Feb 3, 2018
commit d21c534884eaac2f85863dc2b83748d0bb54914f
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ OpenStack services, and versions of services, are supported.
* [Contributing guide](/CONTRIBUTING.md)
* [Code of Conduct](/CODE_OF_CONDUCT.md)

## Backward incompatibility

Due to new [object typehint](https://wiki.php.net/rfc/object-typehint) since PHP 7.2, class `OpenStack\ObjectStore\v1\Models\Object` had to be renamed to `OpenStack\ObjectStore\v1\Models\StorageObject`

## Getting help

- Meet us on Slack: https://phpopencloud.slack.com ([Get your invitation](https://slackpass.io/phpopencloud))
Expand Down
12 changes: 6 additions & 6 deletions doc/services/object-store/v1/objects.rst
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Download an object
------------------

.. sample:: object_store/v1/objects/download.php
.. refdoc:: OpenStack/ObjectStore/v1/Models/Object.html#method_download
.. refdoc:: OpenStack/ObjectStore/v1/Models/StorageObject.html#method_download

As you will notice, a Stream_ object is returned by this call. For more information about dealing with streams, please
consult `Guzzle's docs`_.
Expand Down Expand Up @@ -88,19 +88,19 @@ Copy object
-----------

.. sample:: object_store/v1/objects/copy.php
.. refdoc:: OpenStack/ObjectStore/v1/Models/Object.html#method_copy
.. refdoc:: OpenStack/ObjectStore/v1/Models/StorageObject.html#method_copy

Delete object
-------------

.. sample:: object_store/v1/objects/delete.php
.. refdoc:: OpenStack/ObjectStore/v1/Models/Object.html#method_delete
.. refdoc:: OpenStack/ObjectStore/v1/Models/StorageObject.html#method_delete

Get metadata
------------

.. sample:: object_store/v1/objects/get_metadata.php
.. refdoc:: OpenStack/ObjectStore/v1/Models/Object.html#method_getMetadata
.. refdoc:: OpenStack/ObjectStore/v1/Models/StorageObject.html#method_getMetadata

The returned value will be a standard associative array, or hash, containing arbitrary key/value pairs. These will
correspond to the values set either when the object was created, or when a previous ``mergeMetadata`` or
Expand All @@ -110,7 +110,7 @@ Replace all metadata with new values
------------------------------------

.. sample:: object_store/v1/objects/reset_metadata.php
.. refdoc:: OpenStack/ObjectStore/v1/Models/Object.html#method_resetMetadata
.. refdoc:: OpenStack/ObjectStore/v1/Models/StorageObject.html#method_resetMetadata

In order to replace all existing metadata with a set of new values, you can use this operation. Any existing metadata
items which not specified in the new set will be removed. For example, say an account has the following metadata
Expand Down Expand Up @@ -140,7 +140,7 @@ Merge new metadata values with existing
---------------------------------------

.. sample:: object_store/v1/objects/merge_metadata.php
.. refdoc:: OpenStack/ObjectStore/v1/Models/Object.html#method_mergeMetadata
.. refdoc:: OpenStack/ObjectStore/v1/Models/StorageObject.html#method_mergeMetadata

In order to merge a set of new metadata values with the existing metadata set, you can use this operation. Any existing
metadata items which are not specified in the new set will be preserved. For example, say an account has the following
Expand Down