Travis: fix build and other tweaks #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The build was running on `xenial` which does not have `ant` installed by default, nor has PHP 5.4/5.5 images available.
Switching to the `trusty` distribution fixes this.
* Support for `sudo: false` has been removed from Travis over a year ago.
* Test against PHP 7.3, 7.4 and PHP `nightly` (= PHP 8), allowing the build against PHP 8 to fail for now.
The build script was still pointing to an outdated dependency.
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis: fix build and other tweaks
xenialwhich does not haveantinstalled by default, nor has PHP 5.4/5.5 images available.Switching to the
trustydistribution fixes this.sudo: falsehas been removed from Travis over a year ago.nightly(= PHP 8), allowing the build against PHP 8 to fail for now.Fix build script
The build script was still pointing to an outdated dependency.
Note: even though the PHPCS part of the build is failing, the build isn't being failed. I suspect this has to do with the
failonerror="true"attribute missing from the PHPCS command in thebuild.xmlfile.