Skip to content

Fix branch target in zend_jit_push_call_frame() #17949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

nielsdos
Copy link
Member

Introduced by accident in 3b4a58d. Will request a cherry-pick.
Apologies for this.

Introduced by accident in 3b4a58d.
Will request a cherry-pick.
@nielsdos nielsdos marked this pull request as ready for review February 27, 2025 21:32
@nielsdos nielsdos requested a review from dstogov as a code owner February 27, 2025 21:32
@nielsdos nielsdos merged commit 422e90d into php:PHP-8.3 Feb 28, 2025
9 checks passed
nielsdos added a commit that referenced this pull request Feb 28, 2025
* PHP-8.3:
  Fix branch target in zend_jit_push_call_frame() (#17949)
nielsdos added a commit that referenced this pull request Feb 28, 2025
* PHP-8.4:
  Fix branch target in zend_jit_push_call_frame() (#17949)
@nielsdos
Copy link
Member Author

@NattyNarwhal @ericmann @bukka Can you please cherry-pick this into the upcoming 8.3 release? Sorry for the trouble...

@NattyNarwhal
Copy link
Member

Did you mean the 8.3 or 8.4 release? You tagged both 8.3 and 8.4 RMs, so I'm not sure which.

@nielsdos
Copy link
Member Author

I looked at the wrong place in https://wiki.php.net/todo/php83
I meant 8.3 RMs, this bug only affects 8.3. 8.4 and up are unaffected because they don't have the old JIT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants