Gh18976 #18977
Closed
Gh18976 #18977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
reviewed
Jun 29, 2025
ext/standard/pack.c
Outdated
| efree(formatargs); | ||
| zend_value_error("Type %c: integer overflow in format string", code); | ||
| RETURN_THROWS(); | ||
| } | ||
| INC_OUTPUTPOS((arg + (arg % 2)) / 2,1) /* 4 bit per arg */ |
There was a problem hiding this comment.
Another approach may be to compute arg/2 + arg%2 instead. I believe this does the same thing but can't overflow.
There was a problem hiding this comment.
ok that s more efficient.
nielsdos
approved these changes
Jun 29, 2025
| @@ -0,0 +1,14 @@ | |||
| --TEST-- | |||
| GH-18976 pack overflow wit h/H format | |||
There was a problem hiding this comment.
Suggested change
| GH-18976 pack overflow wit h/H format | |
| GH-18976 (pack overflow with h/H format) |
nielsdos
reviewed
Jun 29, 2025
| @@ -0,0 +1,14 @@ | |||
| --TEST-- | |||
| GH-18976 (pack overflow wit h/H format) | |||
adding with its own remainder, INT_MAX overflows here (negative values are discarded). close phpGH-18977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.