uri: Simplify memory-management in php_uri_parse()
#19928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
approved these changes
Sep 23, 2025
We can try parsing before allocating the `uri_internal_t` struct.
TimWolla
force-pushed
the
uri-parse-memory-management
branch
from
630ee14 to
2f4e857
Compare
|
For RMs: Would like to merge this in 8.5 to reduce avoidable differences between 8.5 and master while still in RC. It's not a bugfix, but a small cleanup that doesn't affect behavior. Is that good with you? Branch is already based on 8.5, so would just need a target branch change without NEWS. |
kocsismate
approved these changes
Oct 12, 2025
DanielEScherzer
approved these changes
Oct 14, 2025
TimWolla
added a commit
that referenced
this pull request
Oct 14, 2025
* PHP-8.5: uri: Simplify memory-management in `php_uri_parse()` (#19928)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can try parsing before allocating the
uri_internal_tstruct.Extracted from #19624.