Skip to content

[WIP] Implement Comparator interface #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WIP] Implement Comparator interface #2143

wants to merge 1 commit into from

Conversation

DASPRiD
Copy link
Contributor

@DASPRiD DASPRiD commented Sep 26, 2016

This is a proposed patch for the Comparator interface RFC. It currently only contains the interface definition itself, but is lacking tests and the actual code which makes use of the interface (I couldn't figure out how to do the latter yet).

@DASPRiD DASPRiD changed the title Implement Comparator interface [WIP] Implement Comparator interface Sep 26, 2016
@nikic nikic added the RFC label Sep 26, 2016
@marcioAlmada
Copy link
Contributor

marcioAlmada commented Sep 28, 2016

@DASPRiD did you check @nikic's comparable extension?

There is also another RFC by @pmtarantino and @sgolemon with a more in-depth proposal you may want to look https://wiki.php.net/rfc/operator-overloading.

Cheers.

@Strate
Copy link

Strate commented Oct 10, 2016

Interface name should definetely be Comparable, not Comparator.

@corphi
Copy link

corphi commented Oct 11, 2016

There also is an older RFC using the Java names.

@KalleZ
Copy link
Member

KalleZ commented Mar 2, 2019

Closing this due to inactivity. Please open a new PR and link to this if active work is being put back into it.

Please use an RFC if you decide to pick this one up

@KalleZ KalleZ closed this Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants