Skip to content

Fix PCRE2 exclusion and remove dead libs in Makefile.gcov #3503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix PCRE2 exclusion and remove dead libs in Makefile.gcov #3503

wants to merge 1 commit into from

Conversation

carusogabriel
Copy link
Contributor

Probably a leftover from #2857

/cc @weltling

@weltling
Copy link
Contributor

weltling commented Sep 8, 2018

@carusogabriel clear, there is no need to produce coverage for PCRE.

Thanks.

@cmb69
Copy link
Member

cmb69 commented Sep 8, 2018

ext/mbstring/oniguruma could also be excluded, since it's a bundled external library, too.

@php-pulls
Copy link

Comment on behalf of carusogabriel at php.net:

Labelling

@carusogabriel
Copy link
Contributor Author

@cmb69 ext/mbstring/oniguruma is already included in the exclusion list of GCOV.

@weltling Thanks for reviewing it. Merged as 5df4955.

@carusogabriel carusogabriel deleted the exclude-bundle-libs-gcov branch September 8, 2018 13:06
@cmb69
Copy link
Member

cmb69 commented Sep 8, 2018

@carusogabriel Ah, thanks. Sorry for the noise!

@Gemorroj
Copy link
Contributor

Gemorroj commented Sep 8, 2018

@carusogabriel Maybe need backport to branch 7.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: Build System
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carusogabriel @weltling @cmb69 @php-pulls @Gemorroj