Always generate fatal error for LSP failures #4000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
force-pushed
the
inheritance-error
branch
from
214943d to
bc1eaaf
Compare
morrisonlevi
reviewed
Apr 8, 2019
| Class D extends C { function f(array $a) {} } | ||
| ?> | ||
| ==DONE== | ||
| --EXPECTF-- | ||
| Warning: Declaration of D::f(array $a) should be compatible with C::f($a) in %s on line 5 | ||
| Array hint, should be nothing. | ||
| ==DONE== |
There was a problem hiding this comment.
The ==DONE== looks like it was removed from expected text, but not from the program.
|
Merged as fd2db11 into master, with a few more "done" messages dropped per Levi's comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/lsp_errors
When a method signature (LSP) check during inheritance fails, always generate a fatal compile error. Previously, this generated either a warning or a fatal error based on the following rules:
This change removes the distinction between abstract and non-abstract methods and always generates a fatal error.