Fix #80268: loadHTML() truncates at NUL bytes #6368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libxml2 has no issues parsing HTML strings with NUL bytes; these are just ignored. Particularly, `::loadHTMLFile()` already supports NUL bytes, so `::loadHTML()` should as well.
nikic
reviewed
Oct 22, 2020
Actually, libxml does not replace NUL bytes with spaces, but rather truncates text content at NUL bytes, but generally continues parsing. Anyhow, `loadHTML()` and `loadHTMLFile()` should behave the same in this regard.
nikic
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libxml2 has no issues parsing HTML strings with NUL bytes; these are
just ignored. Particularly,
::loadHTMLFile()already supports NULbytes, so
::loadHTML()should as well.