RFC: Change default mysqli error mode #6629
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To double check, the current plan is to land this as-is (without deprecation) according to the accepted RFC? If so, could you please rebase the PR? |
|
Please also add a note to UPGRADING about this change. |
kamil-tekiela
force-pushed
the
mysqli-error-mode
branch
from
0beb6c7 to
454d9be
Compare
nikic
approved these changes
Mar 15, 2021
The RFC was accepted without a deprecation notice. I believe someone should create another RFC to propose how we could delay this until PHP 8.2 with a deprecation notice for PHP 8.1 |
|
Document this breaking change on https://www.php.net/manual/en/mysqli-driver.report-mode.php ? |
|
@peterdd Thanks. We will once PHP 8.1 is released or soon before it, together with all other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for https://wiki.php.net/rfc/mysqli_default_errmode