Safe casting functions

[hikari-no-yume]

https://wiki.php.net/rfc/safe_cast

[theodorejb]

It might also be good to have a test for to_int((string) PHP_INT_MAX . "0"). This is a case that bit my implementation at one point.

[theodorejb]

These assertions might make more sense under the "shouldn't pass" section since we no longer truncate.

[hikari-no-yume]

We never did... the "shouldn't pass" section is poorly labelled.

[theodorejb]

I'm referring to the change in 9d135f7, and the assertions on lines 38-39.

[hikari-no-yume]

Oh, right. Still...

[hikari-no-yume]

@theodorejb I see no reason to check for to_int((string) PHP_INT_MAX . "0")... it's not particularly special.

[theodorejb]

@TazeTSchnitzel Hmm, maybe it depends on your implementation. Right now there are tests for float overflows, but not string overflows.

[hikari-no-yume]

Good point, I'll need to handle that.

[theodorejb]

Do to_int and to_float fail with blank strings? I think there should be a test for this.

[hikari-no-yume]

As it happens, they do. But I'll add a test for that.

[hikari-no-yume]

Done!

[krakjoe]

zend_strpprintf(0, "%.*G", (int) EG(precision), Z_DVAL_P(var));

max_len is first parameter ... http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_exceptions.h#57

[hikari-no-yume]

Alright, if I do that, I just get this:

Segmentation fault: 11

[krakjoe]

With this patch applied:

diff --git a/ext/standard/type.c b/ext/standard/type.c
index 3c1d4a7..12e5320 100644
--- a/ext/standard/type.c
+++ b/ext/standard/type.c
@@ -546,25 +546,7 @@ PHP_FUNCTION(to_string)
                        RETURN_STR(zend_long_to_str(Z_LVAL_P(var)));

                case IS_DOUBLE:
-                       /* This code, despite being used in many other places, segfaults
-                        * Since I can't figure out why, it's commented out for now
-                        * This is a shame, as an extra malloc is always bad
-                        * TODO: Stop this segfaulting so we can use it instead
-                        */ 
-                       /*RETVAL_STR(zend_strpprintf("%.*G", (int) EG(precision), Z_DVAL_P(var)));*/
-
-                       {
-                               char *str;
-                               zend_string *zstr;
-                               int len;
-
-                               str = emalloc(MAX_LENGTH_OF_DOUBLE + EG(precision) + 1);
-                               len = zend_sprintf(str, "%.*G", (int) EG(precision), Z_DVAL_P(var));
-                               zstr = zend_string_init(str, len, 0);
-                               RETVAL_STR(zstr);
-                               efree(str);
-                       }
-                       return;
+                       RETURN_STR(strpprintf(0, "%.*G", (int) EG(precision), Z_DVAL_P(var)));

                case IS_OBJECT:
                        {

I pass to_string test.

[hikari-no-yume]

RFC was rejected, forgot to close earlier.