Skip to content

Fix forgetting static property access after impure call #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 20, 2025
Merged

Fix forgetting static property access after impure call #3950

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1099690
Fix forgetting static property access after impure call
staabm Apr 19, 2025
a128206
added regression test
staabm Apr 19, 2025
2a79d7b
Added regression test
staabm Apr 19, 2025
247db4c
Fix forgetting expressions on function calls / closure invoke
staabm Apr 19, 2025
b5cf7d3
Update NodeScopeResolver.php
staabm Apr 19, 2025
d17e41f
Update MutatingScope.php
staabm Apr 19, 2025
5725c3a
Update NodeScopeResolver.php
staabm Apr 20, 2025
ddbd27f
fix name resolving
staabm Apr 20, 2025
1b17eaf
Update MutatingScope.php
staabm Apr 20, 2025
36dc4a4
Added regression test
staabm Apr 20, 2025
54cf6eb
Added regression test
staabm Apr 20, 2025
2327cc0
Added regression test
staabm Apr 20, 2025
8107134
Update ReturnTypeRuleTest.php
staabm Apr 20, 2025
f090339
Update NodeScopeResolver.php
staabm Apr 20, 2025
733d883
cleanup
staabm Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update NodeScopeResolver.php
  • Loading branch information
@staabm
staabm committed Apr 20, 2025
commit 5725c3a1555a91564f33108f749dd8f139220231
2 changes: 1 addition & 1 deletion src/Analyser/NodeScopeResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2598,7 +2598,7 @@ static function (): void {
}

if (
$parametersAcceptor instanceof ClosureType && $parametersAcceptor->getReturnType()->isVoid()->yes()
$parametersAcceptor instanceof ClosureType && count($parametersAcceptor->getImpurePoints()) > 0
&& $scope->isInClass()
) {
$scope = $scope->invalidateExpression(new Variable('this'), true);
Expand Down