Feature/restart activity worker #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, in case of unhandled error - I want to restart the worker instead of calling `process.exit` and relying on recluster to restart the app. If you call worker.close - will effectively remove the listeners and reduce the number of pools to 0. That is why i couldn't just call `close -> start`.
|
Hello @MichaelKovalchuk, Thanks for the PR, this is a good feature. Few remarks :
I will suggest another version in few days and it would be great if can review it and confirm it fits your needs |
piercus
added a commit
that referenced
this pull request
Jan 28, 2019
|
Totally agree. Closing this PR in favour of #13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, in case of unhandled error, I want to restart the worker instead of calling
process.exitand relying on recluster to restart the app.worker.closewill effectively remove the listeners and reduce the number of pools to 0. That is why i couldn't just callclose -> start.