Skip to content

resource control: support more mode for BURSTABLE #20020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

resource control: support more mode for BURSTABLE #20020

wants to merge 18 commits into from
+64 −49

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Mar 7, 2025 •
edited by hfxsd
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2025
@songrijie songrijie self-requested a review March 7, 2025 02:48
@lhy1024
fix
c87dcee 
Signed-off-by: lhy1024 <[email protected]>
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. and removed missing-translation-status This PR does not have translation status info. labels Mar 10, 2025
@hfxsd hfxsd self-assigned this Mar 10, 2025
songrijie
songrijie reviewed Mar 12, 2025
View reviewed changes
songrijie
songrijie reviewed Mar 12, 2025
View reviewed changes
songrijie
songrijie reviewed Mar 12, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 12, 2025

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. labels Mar 18, 2025
@hfxsd hfxsd added the v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2. label Mar 31, 2025
@lhy1024
Copy link
Contributor Author

lhy1024 commented Apr 27, 2025

@hfxsd ptal

@lilin90 lilin90 assigned lilin90 and unassigned hfxsd May 29, 2025
@lilin90 lilin90 requested review from lilin90 and hfxsd May 29, 2025 07:53
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lilin90. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lilin90 lilin90 mentioned this pull request Jun 9, 2025
Open
16 tasks
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 11, 2025
lilin90
lilin90 reviewed Jun 11, 2025
View reviewed changes
lhy1024 and others added 10 commits June 11, 2025 16:30
@lhy1024 @lilin90
Update information-schema/information-schema-resource-groups.md
df0a206 
Co-authored-by: Lilian Lee <[email protected]>
@lhy1024 @lilin90
Update information-schema/information-schema-resource-groups.md
ac2c3bb 
Co-authored-by: Lilian Lee <[email protected]>
@lhy1024 @lilin90
Update sql-statements/sql-statement-create-resource-group.md
049c96b 
Co-authored-by: Lilian Lee <[email protected]>
@lhy1024 @lilin90
Update tidb-resource-control-ru-groups.md
7ea1e6d 
Co-authored-by: Lilian Lee <[email protected]>
@lhy1024 @lilin90
Update tidb-resource-control-ru-groups.md
e0034c2 
Co-authored-by: Lilian Lee <[email protected]>
@lhy1024 @lilin90
Update tidb-resource-control-ru-groups.md
f1d3139 
Co-authored-by: Lilian Lee <[email protected]>
@lhy1024 @lilin90
Update information-schema/information-schema-resource-groups.md
aa316af 
Co-authored-by: Lilian Lee <[email protected]>
@lhy1024 @lilin90
Update sql-statements/sql-statement-create-resource-group.md
0aa5863 
Co-authored-by: Lilian Lee <[email protected]>
@lilin90
Update wording for consistency
ef332af
@lilin90
Remove tabs
ddbafce
lilin90
lilin90 reviewed Jun 16, 2025
View reviewed changes
information-schema/information-schema-resource-groups.md
@@ -77,8 +79,11 @@ SELECT * FROM information_schema.resource_groups WHERE NAME = 'rg1'; -- 查看
* `NAME`：资源组名称。
* `RU_PER_SEC`：资源组的回填速度，单位为每秒回填的 [Request Unit (RU)](/tidb-resource-control-ru-groups.md#什么是-request-unit-ru) 数量。
* `PRIORITY`：任务在 TiKV 上处理的绝对优先级。不同的资源按照 `PRIORITY` 的设置进行调度，`PRIORITY` 高的任务会被优先调度。如果资源组的 `PRIORITY` 相同，则会根据 `RU_PER_SEC` 的配置按比例调度。如果不指定 `PRIORITY`，资源组的默认优先级为 `MEDIUM`。
* `BURSTABLE`：是否允许此资源组超额使用剩余的系统资源。
* `BURSTABLE`：是否允许此资源组超额使用剩余的系统资源。支持以下三种模式，如果没有为 `BURSTABLE` 指定目标值，将默认启用 `MODERATED` 模式。
- `OFF`：表示不允许此资源组超额使用剩余的系统资源；
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 72 里 BURSTABLE 列值为 NO，这里的描述是否需要保持一致？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

@songrijie songrijie songrijie approved these changes

@hfxsd hfxsd Awaiting requested review from hfxsd

Assignees

@lilin90 lilin90

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lhy1024 @songrijie @lilin90 @hfxsd