Skip to content

Fix running project on Windows #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2021
Merged

Fix running project on Windows #29

merged 3 commits into from
Jun 5, 2021

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Mar 19, 2021

go run ./examples/Open in this project resulted in an error on Windows because the runtime now references a golang.org/x/sys package that wasn't listed in go.mod.

Also un-exports Windows-specific identifiers.

Also removes the setFlags func which is now a no-op across all platforms.

Ref. #27

Copy link
Collaborator

@luna-duclos luna-duclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Going to let it sit for a day or two to give Dave a chance to look at it as well, and then merge it

@luna-duclos luna-duclos merged commit 99a9298 into pkg:master Jun 5, 2021
@mislav mislav deleted the windows-fix branch June 5, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants