Increase App Engine urlfetch deadline #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, App Engine's native `urlfetch` module has a deadline of 5 seconds. Since many Plaid API requests can take longer, we increase the deadline to one minute.
|
(CI build seems to be failing due to an unrelated change in the Plaid backend - looks like the last CI build before now was a couple months ago) |
|
Thanks for the PR, @nfarina! 60s is a reasonable timeout. You're right that the CI build failure seems unrelated. We'll investigate and fix that shortly. |
|
Merging now that CI is passing |
charleswli
added a commit
that referenced
this pull request
Feb 22, 2016
Increase App Engine urlfetch deadline
|
Awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, App Engine's native
urlfetchmodule has a deadline of 5 seconds. Since many Plaid API requests can take longer (causing the API request to fail withDeadlineExceededException), we increase the deadline to one minute.This seems like a reasonable number but perhaps the Plaid team knows a better upper limit.