Skip to content

Conversation

@n17r4m
Copy link
Contributor

@n17r4m n17r4m commented Aug 2, 2017

When trying to plot my violin, I noticed rugplot=False was not being respected. This is a proposed fix.
As a point of discussion, should the rugplot=True|False property name be normalized between the figure factories? For example, in _distplot.py the corresponding property name is "show_rug" instead of "rugplot".

When trying to plot my violin, I noticed rugplot=False was not being respected. This is a proposed fix.
As a point of discussion, should the rugplot=True|False property name be normalized between the figure factories? For example, in _distplot.py the corresponding property name is "show_rug" instead of "rugplot".
@cldougl
Copy link
Member

cldougl commented Aug 4, 2017

Hey @n17r4m could you let me know what issue you're having exactly? rugplot=False seems to be working for me but maybe you're expecting a different result. Here's an example: https://plot.ly/~chelsea_lyn/15199

@n17r4m
Copy link
Contributor Author

n17r4m commented Aug 4, 2017

I'm very sorry, I should have added some more information.

The issue is experienced when using plotly.offline when drawing multiple violin plots (which, as I found out, requires the use of pandas DataFrames, which I think is a separate concern, as sending in arrays of data arrays is not supported by the current violin implementation, i.e. [[1, 2, 3], [2, 3 4]] does not work as expected.)

Edit: as a minimal example, adding rugplot=False, to the https://plot.ly/python/violin-plot/#multiple-violins example yields a plot that still has the rugplots.

@cldougl
Copy link
Member

cldougl commented Aug 7, 2017

@n17r4m got it- thanks for the fix!

@cldougl cldougl merged commit 8fb58d5 into plotly:master Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants