Skip to content

Make offline_js_sources pub #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Conversation

alexespencer
Copy link

This function is useful outside of the crate. Example use case: assembling multiple plotly chart div HTML elements into a single page, after injecting the plotly scripts via offline_js_sources. I've been able to then embed plotly graphs inside HTML pages generated with rusts mdbook, however I had to replicate this function externally - which is OK but creates a problem when bumping plotly as I would have to re-download these scripts which may change.

@andrei-ng
Copy link
Collaborator

Hi @alexespencer ,

If it is useful to be public, let's make the function public. I see no problem with that!

@andrei-ng andrei-ng merged commit 30fa08d into plotly:main Jul 4, 2025
24 of 27 checks passed
@alexespencer
Copy link
Author

@andrei-ng thanks - do you know when the next release is planned? (Can it be soon? 🙏 )

@alexespencer alexespencer deleted the asp/pub-offline branch July 7, 2025 09:32
@andrei-ng
Copy link
Collaborator

andrei-ng commented Jul 7, 2025

@andrei-ng thanks - do you know when the next release is planned? (Can it be soon? 🙏 )

@alexespencer Good question. I have been working on a new package in order to replace the Kaleido feature. I am almost done and want to squeeze that in the new release. Haven't decided if to deprecate kaleido now or just give users some more time to test with the new upcoming crate/feature. I will decide in the next days and hopefully make a new release before the 16th. Alternatively, my next window would be early August

@andrei-ng
Copy link
Collaborator

@alexespencer , I've decided to bite the bullet and release earlier. Version 0.13.1 is out

@alexespencer
Copy link
Author

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants