[java] corrected invalid reporting of LoD violation #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsotuyod
changed the title
jsotuyod
added a commit
to jsotuyod/pmd
that referenced
this pull request
Feb 22, 2017
|
@wje600 thanks for the amazing PR! This will be included in PMD 5.4.5, PMD 5.5.4 and later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, prefix the PR title with the language it applies to within brackets, such as [java] or [apex]. If not specific to a language, you can use [core]
Before submitting a PR, please check that:
master. The PMD team will merge back to support branches as needed.mvn testpasses.mvn checkstyle:checkpasses. Check this for more infoPR Description:
Corrected issue where LawOfDemeter exceptions were being reported erroneously if additional (unrelated) assignments occurred later in the same block (method). (See new test for an example of a condition that causes erroneous error reporting.)
Fixes #270