Skip to content

[java] Fix class scopes for anon inner classes #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

jsotuyod
Copy link
Member

@jsotuyod jsotuyod added the a:bug PMD crashes or fails to analyse a file. label Feb 26, 2017
@jsotuyod jsotuyod added this to the 5.5.5 milestone Feb 26, 2017
@jsotuyod
Copy link
Member Author

@adangel please check Travis, it's failing with:

The command "openssl aes-256-cbc -K $encrypted_5630fbebf057_key -iv $encrypted_5630fbebf057_iv -in .travis/secrets.tar.enc -out .travis/secrets.tar -d" failed and exited with 1 during .

@adangel
Copy link
Member

adangel commented Feb 27, 2017

I think, I've fixed the travis build. Didn't think about that secure vars are not available for pull requests.
Could you please rebase this PR against master and give it another try?

 - A new ClassScope was being created for each annon inner class method / field,
    which is incorrect.
 - I reworked the AccessorMethodGeneration to compare scopes directly, since
    I was missing anonymous classes completely.
 - Fixes pmd#274
@jsotuyod
Copy link
Member Author

@adangel thanks! I just rebased and it built just fine!

@adangel adangel merged commit c67e3b5 into pmd:master Mar 3, 2017
@jsotuyod jsotuyod deleted the issue-274 branch March 3, 2017 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug PMD crashes or fails to analyse a file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants