refactor: Use new URL for connection string parsing #1127
+35
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the connection URL parsing logic in
src/index.js
to use thenew URL()
constructor. This change provides a more robust and standardized way to parse connection strings, addressing several limitations of the previous implementation:To achieve this, the
parseUrl
function was rewritten to replace thepostgres://
orpostgresql://
protocol withhttp://
before passing the string to theURL
constructor. This allows the use of the standard URL parsing mechanism for a custom protocol.Additionally, two new helper functions,
parseHost
andparsePort
, have been introduced to correctly extract host and port information from various formats, including single-host, multi-host, and IPv6 addresses.