Skip to content

corrects explnation of default max_lifetime values in README.md #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2024

Conversation

oakgary
Copy link
Contributor

@oakgary oakgary commented May 15, 2024

The current version of the README states:

Note that max_lifetime = 60 * (30 + Math.random() * 30) by default. This resolves to an interval between 45 and 90 minutes to optimize for the benefits of prepared statements and working nicely with Linux's OOM killer.

The range of 60 * (30 + Math.random() * 30) is 1800-3600, therefore 30 to 60 minutes.

Both versions define the max_lifetime as 60 * (30 + Math.random() * 30)

return 60 * (30 + Math.random() * 30)

return 60 * (30 + Math.random() * 30)

@porsager
Copy link
Owner

Uh, nicely spotted ! Thanks!

@porsager porsager merged commit e05585b into porsager:master May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants