Skip to content

Disable expressify code caching on Pyodide #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Disable expressify code caching on Pyodide #1046

merged 3 commits into from
Jan 22, 2024

Conversation

wch
Copy link
Collaborator

@wch wch commented Jan 22, 2024

Fixes #1042.

This PR works around a bug in Pyodide 0.22.1 where the hash of a function bytecode seems to ignore specific kinds of changes to functions. See #1042 (comment) for detailed information.

@wch wch requested a review from jcheng5 January 22, 2024 16:12
@wch wch mentioned this pull request Jan 22, 2024
55 tasks
@wch wch added this to the v0.7.0 milestone Jan 22, 2024
@wch wch merged commit 1cddb17 into main Jan 22, 2024
@wch wch deleted the pyodide-express branch January 22, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@expressify puts shinylive into a strange state
2 participants