only report wait times from clients currently waiting to match behavior of pgbouncer #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbabiak
force-pushed
the
dbabiak/fix-maxwait-stats
branch
from
97a91f6 to
b6cdc78
Compare
…ng to match behavior of pgbouncer
dbabiak
force-pushed
the
dbabiak/fix-maxwait-stats
branch
from
b6cdc78 to
5bb99c2
Compare
|
Looks like one of our integration tests caught this change and needs to be updated. |
|
Just tweaked the integration tests, @levkk what do you think? |
|
Amazing, thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maxwait reported by pgcat differs in how it's measured from pgbouncer
maxwait in pgbouncer
Pgcat instead tracked the longest wait time ever encountered by a client.
If a client in pgcat waited for a few seconds during a slow period, it would continue to report a high maxwait until it disconnects, even all of its subsequent queries have low wait times.
This changes pgcat behavior to match pgbouncer; max wait reported is now the max over all clients currently waiting.
https://discord.com/channels/1013868243036930099/1015389720622153819/1181065797892853771