Bump the hyper crate to v1.4.1 and rework prometheus server handling #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@levkk can I request you for a review? Thanks! |
|
I am triggering a CI build on your PR |
|
Tests are passing the failure is unrelated. I am merging this. |
AndrewJackson2020
pushed a commit
to AndrewJackson2020/pgcat
that referenced
this pull request
Sep 3, 2024
…ostgresml#778) Bump hyper to v1.4.1 and rework prometheus server handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi folks! While trying to build
pgcatinside a private repository, I noticed that thehyperversion is < 1.0. The current version is v1.4.1.This PR bumps it to the latest version and addresses the breaking changes in the
hyperlibrary.Note: the
make_service_fnmethod is no longer available, and I used the guide here to achieve equivalent functionality as far as I can tell.Testing strategy
Started a local pgcat server
Ran
curl localhost:9930/metricsto fetch collected metricsThe output is documented here: https://gist.github.com/sarajmunjal/8ed041db1cbdca23cfa54a2c4f8fd863
Also ran unit tests locally